Skip to content

make package plone 6.2 ready#470

Merged
1letter merged 16 commits into
masterfrom
meta
Apr 20, 2026
Merged

make package plone 6.2 ready#470
1letter merged 16 commits into
masterfrom
meta

Conversation

@1letter
Copy link
Copy Markdown
Contributor

@1letter 1letter commented Apr 15, 2026

No description provided.

@szakitibi
Copy link
Copy Markdown
Contributor

szakitibi commented Apr 16, 2026

Based on the traceback it seems to fail due to 6.1 constraints.txt pinning the old Products.validation==3.0.0. This version is the pre reverseTranslation fix version - see plone/Products.validation#15.

Interestingly for 6.0 constraints.txt is pinned correctly to Product.validation==3.0.1.

I have created plone/buildout.coredev#1086 to report it.

I assume this is a plone/Products.CMFPlone#3928 related PR, but I seen collective.easyform mentioned there only in this comment.

This is a bit confusing, since according to the classic.demo.plone.org's Add-ons controlpanel collective.easyform is installed by default. For this reason I assume it is considered as a somewhat core product in the Plone community.

Shouldn't this PR be considered part of the 6.2 push too?

@1letter 1letter requested a review from petschki April 20, 2026 11:21
petschki
petschki requested changes Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@petschki petschki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general +1 ... see comment

and maybe add a news/ folder, then plone/meta implements towncrier changelog.

I'd also try uvx plone-codemod src/ --bootstrap --dry-run and look, what it means. This tool is pretty handy to detect wrong imports and eventually bootstrap fixes for classic-ui.

Comment thread .meta.toml Outdated
@1letter
Copy link
Copy Markdown
Contributor Author

1letter commented Apr 20, 2026

@petschki i run the cool tool plone-codemod (amazing) and removed the PloneFormGen migration code

petschki
petschki reviewed Apr 20, 2026
View reviewed changes
Comment thread news/+config.breaking Outdated
@petschki
Copy link
Copy Markdown
Member

petschki commented Apr 20, 2026

good to merge! 👍🏼

@1letter 1letter merged commit 5605528 into master Apr 20, 2026
11 checks passed
@1letter 1letter deleted the meta branch April 20, 2026 12:37
This was referenced Apr 21, 2026
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petschki petschki petschki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@1letter @szakitibi @petschki